Add reproducible x86 assembly checks#18
Merged
falseywinchnet merged 1 commit intoJun 12, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
make asm-checktarget that probes the compiler for AVX2/FMA and SSE2/no-AVX support and emits annotated assembly intobuild/src/bfft_avx2.sandbuild/src/bfft_sse2.swhen available by using$(AVX2_FLAGS)and$(SSE2_FLAGS)in the Makefile.make/make testflow so normal builds continue to use the automatic SIMD policy.src/ASSEMBLY_NOTES.txtwith audit findings and benchmark spot checks describing AVX2/SSE2 shapes, a rejected SSE fusion experiment (high register pressure), and example benchmark numbers observed during inspection.Testing
make clean,make, andmake testwith the automatic SIMD selection and all library correctness tests passed.make asm-checkwhich producedbuild/src/bfft_avx2.sandbuild/src/bfft_sse2.son a host compiler that accepted those switches../build/examples/benchmark 4096 1000,./build/examples/benchmark 65536 200, and./build/examples/locality_probe 65536 200 64; these completed and produced the recorded spot-check timings (FFTW columns were unavailable because FFTW/FFTWf were not found bydlopen).benchmarkto validate the SSE pathway (g++ -msse2 -mno-avxcompile); correctness tests passed for the SSE2 build.Codex Task