Enable AVX2 scheduled inverse FFT#38
Merged
falseywinchnet merged 2 commits intoJun 21, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
src/detail/bruun_kernel.hppso AVX2 usesrun_inv_residue_schedulefor N>=64 and added a short rationale comment.inverse_nsand printedInv_nsin the benchmark output by updatingexamples/benchmark.cppto timeplan.inverse(...)and emit the new column.src/detail/inverse_acceleration_notes.txtto record the AVX2 schedule decision, the validation platform/flags, and the rationale that the d4 fusion makes the scheduled inverse beneficial for BRUUN_LEVEL 2.Testing
make -j$(nproc) test examples CXXOPTFLAGS='-O3 -mavx2 -mfma -mno-avx512*'and thecorrectnessandapi_ctests passed (reportedcorrectness ok backend=avx2-fma-256andc api ok backend=avx2-fma-256).build/examples/benchmark) across sizes and used the newInv_nscolumn to compare direct inverse timings, observing an improvement at N=4096 from about ~11071 ns (pre-toggle) to ~10678 ns in the validation sample.make asm-checkand produced AVX2 and SSE2 assembly outputs successfully for inspection.Codex Task