Remove fused q==8 inverse codelets and use scheduled d3+d3+norm inverse path; simplify twiddle helpers#39
Merged
falseywinchnet merged 1 commit intoJun 21, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
codelet_d4_inv_f32,codelet_d4_inv, and wide-ISA fused variants) and replaced q==8 handling with explicit two depth-3 codelet calls plus the q==8 norm (d3 + d3 + norm) in all schedule and recursive call sites.s_twiddle(int)andsf_twiddle(int)to use explicitifbranches returning 0 form==0,C[1]/CF[1]form==1, andC[m^1]/CF[m^1]otherwise.rec_inv_res,run_inv_residue_schedule,rec_inv_resfor double, and forward scheduling spots) to invoke the twod3codelets and thennorm_q_*for q==8, and removed conditional BRUUN_LEVEL paths that used the fused variants.inverse_acceleration_notes.txt) to record the decision to keep q==8 on the sharedd3 + d3 + normpath, list completed changes, and note benchmarking/assembly inspection results.Testing
-O3 -mavx2 -mfmaand native AVX-512 builds, and observed the scheduled inverse running and benchmark output including a directInv_nscolumn. Tests succeeded.Codex Task