Add AVX2 forward-combine path to BODFT kernel#43
Merged
falseywinchnet merged 1 commit intoJun 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
bodft_combine_fwd_avx2_f64and helpersbodft_uzp4_pd,bodft_store4_pd,bodft_rev4_pdinsrc/detail/bodft_kernel.hppand wired it ahead of the existing 128-bit SIMD fallback incombine_fwd.Makefileto emit a BODFT AVX2 assembly target (build/.../src/bodft_avx2.s) and include it inasm-check.src/detail/bodft_avx2_notes.mdto record validation commands, assembly inspection steps, performance observations and next work items.Testing
make test BUILD_DIR=build-avx2 CXXWARNFLAGS='-Wall -Wextra -Wpedantic -Werror'and saw both correctness checks pass (correctness okandc api ok).make build-avx2/examples/bodft_benchmark BUILD_DIR=build-avx2 && build-avx2/examples/bodft_benchmark, which produced correctness output and timing numbers for f64/f32 (completed successfully).make asm-check BUILD_DIR=build-avx2and verified AVX/FMA/ymm patterns viarg 'vfmadd|vfmsub|vperm|ymm' build-avx2/src/bodft_avx2.s, confirming vectorized code emission.make build-avx2/examples/benchmark BUILD_DIR=build-avx2 && build-avx2/examples/benchmark 65536 200to compare end-to-end timings in this environment (completed; platform-specific comparison columns such as FFTW/MKL were unavailable).Codex Task