Add AVX2 double-precision BODFT combine (forward/inverse) and Makefile asm target#44
Merged
falseywinchnet merged 2 commits intoJun 23, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
make asm-checkand document validation/performance notes.Description
bodft_uzp4_pd,bodft_store4_pd,bodft_rev4_pd,bodft_combine_fwd_avx2_f64, andbodft_combine_inv_avx2_f64insrc/detail/bodft_kernel.hppand wire them intocombine_fwd/combine_invunderBRUUN_LEVEL >= 2fordouble(RTsize 8).outputbuffer and simplify ping-pong buffer switching in bothforwardandinverseto avoid an extra final copy.Makefilesoasm-checkemitssrc/bodft_avx2.swhen AVX2 flags are enabled by introducingBODFT_AVX2_ASMand a dedicated rule.src/detail/bodft_avx2_notes.mddescribing the AVX2 paths, validation steps, and performance observations.Testing
make test BUILD_DIR=build-avx2 CXXWARNFLAGS='-Wall -Wextra -Wpedantic -Werror'which completed successfully.make build-avx2/examples/bodft_benchmark BUILD_DIR=build-avx2 && build-avx2/examples/bodft_benchmarkto validate correctness and measure timings, which ran successfully.make asm-check BUILD_DIR=build-avx2and inspectedbuild-avx2/src/bodft_avx2.sto confirm AVX/FMA instructions were emitted as expected.Codex Task