Table-based sin/cos approximation and residue-linear traversal + unrolling for mag/phase paths#63
Merged
falseywinchnet merged 1 commit intoJun 26, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
sin/coscalls in inverse mag/phase hot loops and improve cache locality and throughput for forward/inverse mag-phase transforms.Description
#include <array>and new typesbruun_sincos_sampleand templatedbruun_sincos_table<K>to precompute a power-of-two sin/cos lookup table.bruun_table256_poly3_sincosandbruun_table256_poly3_sincos_f32which perform a table lookup plus a cubic polynomial correction for remainder, and fall back tostd::sin/std::cosfor out-of-range phases.IDX(improving streaming reads) and removed redundant phase-normalization code now handled bybruun_phase_atan2_mag.std::sin/std::coscalls ininverse_mag_phaseandinverse_mag_phase_f32with the table-based approximations, and added 4-element loop unrolling to compute sin/cos for multiple bins per iteration.Testing
Codex Task