Add vec5+cubic vectoring phase path and benchmark comparisons#64
Merged
falseywinchnet merged 2 commits intoJun 27, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
bruun_atan_leaf_cubicresidual helper and preserved the original tree32/degree7 function asbruun_phase_first_octant_tree32_degree7.bruun_phase_vec_stepandbruun_phase_first_octant_vec5_cubicimplementing the vec5+cubic vectoring network, and routed the defaultbruun_phase_first_octantto the vec5 path.bruun_phase_atan2_coretemplate to call a chosen first-octant implementation so the tree32 and vec5 paths can both be exercised without removing either.examples/atan2_benchmark.cppto time and reportstd::atan2, the old tree32 path, the new vec5 path, and sin/cos vs table sin/cos timings.Testing
cmake -S . -B build -DBFFT_BUILD_SHARED=OFF -DBFFT_BUILD_PROBES=OFFwhich completed successfully.cmake --build build --target correctness atan2_benchmark -j2and the build completed successfully../build/correctnesswhich printedcorrectness ok backend=avx2-fma-256(success)../build/atan2_benchmark 1024which executed and reported timings forstd::atan2,bfft tree32,bfft vec5, and sin/cos variants (successful run).Codex Task