Add AVX2 float BODFT forward combine (8-position, FMA)#72
Merged
falseywinchnet merged 1 commit intoJun 27, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
src/detail/bodft_kernel.hppwith helpersbodft_uzp8_ps,bodft_store8_ps,bodft_rev8_psandbodft_combine_fwd_avx2_f32that use AVX2/FMA intrinsics to deinterleave, compute three child twiddle products withvfmaddps/vfmsubps, permute lane-reversed partner bins, and store outputs through an AVX2 packing helper.BRUUN_LEVEL >= 2andsizeof(RT) == 4the new AVX2 float path is used, while the existing 128-bit SSE2/NEON float combine remains the fallback and scalar tail loop remains unchanged.src/detail/bodft_avx2_notes.mddescribing the new float combine, FMA usage, partner-bin permutes, fallback behavior, and validation steps.Testing
cmake --build build -j2and the build completed successfully.ctest --test-dir build --output-on-failureand all tests passed (2/2 tests passed).make asm-check BUILD_DIR=buildand verified AVX2/FMA instructions and permutes were present by searching forvfmadd*ps,vfmsub*ps,vpermd/permutes in the generatedbuild/src/bodft_avx2.s.examples/bodft_benchmark) on an AVX2/FMA build and on an SSE2/no-AVX build to validate correctness and timings; the benchmark completed and printed correctness/timing output for both float and double runs.Codex Task