AVX2: eight-wide f32 BODFT forward/inverse combines, FMA intrinsics and SIMD tail scheduling improvements#73
Merged
falseywinchnet merged 2 commits intoJun 27, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
bodft_uzp8_ps,bodft_store8_ps,bodft_rev8_ps,bodft_combine_fwd_avx2_f32, andbodft_combine_inv_avx2_f32, and wired them intocombine_fwd/combine_invdispatch for float (sizeof(RT)==4).bruun_kernel.hppto use_mm_fmadd_*/_mm_fnmadd_*when__FMA__is defined (falling back to separate mul+add/sub otherwise), and updated 128-bit float/double codelets to shorten live ranges and move loads after rotation start where profitable.kernel_sequentiality_flow.md, updates toinverse_acceleration_notes.txt, and BODFT AVX2 notes (bodft_avx2_notes.md) describing validation and observed performance changes.Testing
make test BUILD_DIR=build-avx2 CXXWARNFLAGS='-Wall -Wextra -Wpedantic -Werror', and the CTest checks passed.make build-avx2/examples/bodft_benchmark BUILD_DIR=build-avx2 && build-avx2/examples/bodft_benchmark, and observed measured improvements (example: double inverse ~748 us -> ~611 us at N=65536; f32 inverse ~1.13 ms -> ~0.78 ms at N=65536).make asm-check BUILD_DIR=build-avx2and inspectedbuild-avx2/src/bodft_avx2.sfor AVX/FMA instructions.Codex Task