Remove AVX-512 backend paths and improve ARM/MSVC SIMD detection#74
Merged
falseywinchnet merged 1 commit intoJun 28, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
__m512/_mm512*codepaths fromsrc/detail/bruun_kernel.hpp, including conditional blocks that compiled 512-bit kernels.BRUUN_HAS_FMAprobe (__FMA__ || _M_FMA) and adjusted the AVX2 level test to requireBRUUN_HAS_FMA, and updated 128-bit x86 and NEON detection to consider MSVC macros (_M_IX86_FP,_M_ARM64,_M_ARM64EC,__ARM_NEON__, and__ARM_NEON).immintrin.handarm_neon.hare pulled only for the supported backends and guarded by the improved detection macros.documentation/python.md,src/detail/inverse_acceleration_notes.txt,src/detail/kernel_sequentiality_flow.md) to remove or reword AVX-512 references.Testing
cmake -S . -B build -DBFFT_BUILD_TESTS=ON -DBFFT_BUILD_EXAMPLES=OFF && cmake --build build -j2 && ctest --test-dir build --output-on-failure, and all tests passed.cmake -S . -B build-no-auto -DBFFT_ENABLE_AUTO_SIMD=OFF -DBFFT_BUILD_TESTS=ON -DBFFT_BUILD_EXAMPLES=OFF && cmake --build build-no-auto -j2 && ctest --test-dir build-no-auto --output-on-failure, and all tests passed.rg -n "AVX-512|avx512|__AVX512|__m512|_mm512") and found no remaining AVX-512 occurrences.clang++ -target aarch64-pc-windows-msvc -fsyntax-onlyattempt to validate MSVC/Windows ARM target handling, which failed in this container due to missing Windows C++ standard library headers and therefore could not fully validate MSVC system headers here.Codex Task