Skip to content

Krille/refactor-archive-room-handling#2217

Open
krille-chan wants to merge 2 commits into
mainfrom
krille/refactor-archive-room-handling
Open

Krille/refactor-archive-room-handling#2217
krille-chan wants to merge 2 commits into
mainfrom
krille/refactor-archive-room-handling

Conversation

@krille-chan

@krille-chan krille-chan commented Jan 2, 2026

Copy link
Copy Markdown
Contributor

closes #2031

Test out with:

Client(
  // ...
 syncFilter: Filter(
    room: RoomFilter(
      includeLeave: true,
      state: StateFilter(lazyLoadMembers: true),
    ),
  ),
);

If you don't change the syncFilter, the behavior should be as before, just that you now have to cache the archive by yourself when requesting it.

@krille-chan krille-chan force-pushed the krille/refactor-archive-room-handling branch from 7320e86 to 44c54ee Compare January 2, 2026 14:32
@codecov

codecov Bot commented Jan 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 73.68421% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.41%. Comparing base (4123392) to head (4f2d4cf).

Files with missing lines Patch % Lines
lib/src/client.dart 75.00% 9 Missing ⚠️
lib/src/database/matrix_sdk_database.dart 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2217      +/-   ##
==========================================
- Coverage   59.49%   59.41%   -0.09%     
==========================================
  Files         161      161              
  Lines       20127    20107      -20     
==========================================
- Hits        11974    11946      -28     
- Misses       8153     8161       +8     
Files with missing lines Coverage Δ
lib/src/room.dart 77.54% <ø> (+0.26%) ⬆️
lib/src/database/matrix_sdk_database.dart 89.96% <50.00%> (-1.54%) ⬇️
lib/src/client.dart 77.72% <75.00%> (-0.05%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4123392...4f2d4cf. Read the comment docs.

@krille-chan krille-chan force-pushed the krille/refactor-archive-room-handling branch from 44c54ee to 129b959 Compare May 15, 2026 06:52
@krille-chan krille-chan force-pushed the krille/refactor-archive-room-handling branch 2 times, most recently from 44634d1 to 84eccf8 Compare June 19, 2026 13:24
@krille-chan krille-chan marked this pull request as ready for review June 19, 2026 13:24
Comment thread lib/src/client.dart
Comment thread lib/src/client.dart
@krille-chan krille-chan force-pushed the krille/refactor-archive-room-handling branch from 84eccf8 to adbe99a Compare June 22, 2026 07:55
@krille-chan krille-chan force-pushed the krille/refactor-archive-room-handling branch from adbe99a to 4f2d4cf Compare June 22, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make it possible to keep leave rooms when syncfilter includes them

1 participant