Skip to content

fix: load keys for decryption separately for [Room].searchEvents#2334

Open
coder-with-a-bushido wants to merge 1 commit into
mainfrom
karthi/load-keys-for-search
Open

fix: load keys for decryption separately for [Room].searchEvents#2334
coder-with-a-bushido wants to merge 1 commit into
mainfrom
karthi/load-keys-for-search

Conversation

@coder-with-a-bushido
Copy link
Copy Markdown
Contributor

@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2026

Codecov Report

❌ Patch coverage is 31.03448% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.38%. Comparing base (2ba4922) to head (6900df9).

Files with missing lines Patch % Lines
lib/src/room.dart 8.33% 11 Missing ⚠️
lib/encryption/key_manager.dart 47.05% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2334      +/-   ##
==========================================
- Coverage   55.76%   55.38%   -0.38%     
==========================================
  Files         160      160              
  Lines       19850    19867      +17     
==========================================
- Hits        11069    11004      -65     
- Misses       8781     8863      +82     
Files with missing lines Coverage Δ
lib/encryption/key_manager.dart 86.09% <47.05%> (-0.88%) ⬇️
lib/src/room.dart 75.64% <8.33%> (-0.62%) ⬇️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ba4922...6900df9. Read the comment docs.

@td-famedly
Copy link
Copy Markdown
Member

@coder-with-a-bushido could use tests

@coder-with-a-bushido coder-with-a-bushido force-pushed the karthi/load-keys-for-search branch from 6900df9 to d72a3d6 Compare May 25, 2026 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants