Skip to content

chore: Allow building the docker image on demand in Github#30

Closed
jason-famedly wants to merge 1 commit into
masterfrom
jason/enable-manual-docker-build
Closed

chore: Allow building the docker image on demand in Github#30
jason-famedly wants to merge 1 commit into
masterfrom
jason/enable-manual-docker-build

Conversation

@jason-famedly
Copy link
Copy Markdown
Member

No description provided.

@jason-famedly jason-famedly requested a review from a team as a code owner April 30, 2025 15:40
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.66%. Comparing base (57a214f) to head (df42ce6).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #30   +/-   ##
=======================================
  Coverage   78.66%   78.66%           
=======================================
  Files         472      472           
  Lines       67653    67653           
  Branches    10419    10419           
=======================================
  Hits        53218    53218           
  Misses      10917    10917           
  Partials     3518     3518           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57a214f...df42ce6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jason-famedly jason-famedly force-pushed the jason/enable-manual-docker-build branch from 5419d33 to df42ce6 Compare April 30, 2025 16:32
@jason-famedly jason-famedly marked this pull request as draft April 30, 2025 16:34
on:
push:
tags: ["v*.*.*_*"]
workflow_dispatch:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe instead enable a workflow to also build night images on branches? I don't really like having random images built without any commit or tag associated with it. Afaik we already have an issue for that as well.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this isn't done yet. I'm still working out how to do the tag bit properly so it would still show up like would be wanted and not just run with some random thing(or heaven forbid getting a 'latest' tag inappropriately)

@jason-famedly
Copy link
Copy Markdown
Member Author

Incorporating this into other work. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants