chore: Allow building the docker image on demand in Github#30
chore: Allow building the docker image on demand in Github#30jason-famedly wants to merge 1 commit into
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #30 +/- ##
=======================================
Coverage 78.66% 78.66%
=======================================
Files 472 472
Lines 67653 67653
Branches 10419 10419
=======================================
Hits 53218 53218
Misses 10917 10917
Partials 3518 3518 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
5419d33 to
df42ce6
Compare
| on: | ||
| push: | ||
| tags: ["v*.*.*_*"] | ||
| workflow_dispatch: |
There was a problem hiding this comment.
Maybe instead enable a workflow to also build night images on branches? I don't really like having random images built without any commit or tag associated with it. Afaik we already have an issue for that as well.
There was a problem hiding this comment.
Yeah this isn't done yet. I'm still working out how to do the tag bit properly so it would still show up like would be wanted and not just run with some random thing(or heaven forbid getting a 'latest' tag inappropriately)
|
Incorporating this into other work. Closing |
No description provided.