Hotfix/v0.45.2.1

.clj-kondo/config.edn

@@ -224,13 +224,14 @@
     metabase.driver.mongo.parameters                                mongo.params
     metabase.driver.mongo.query-processor                           mongo.qp
     metabase.driver.mongo.util                                      mongo.util
+    metabase.driver.sql-jdbc.common                                 sql-jdbc.common
     metabase.driver.sql-jdbc.connection                             sql-jdbc.conn
     metabase.driver.sql-jdbc.execute                                sql-jdbc.execute
     metabase.driver.sql-jdbc.execute.diagnostic                     sql-jdbc.execute.diagnostic
     metabase.driver.sql-jdbc.execute.legacy-impl                    sql-jdbc.legacy
     metabase.driver.sql-jdbc.execute.old-impl                       sql-jdbc.execute.old
     metabase.driver.sql-jdbc.sync                                   sql-jdbc.sync
-    metabase.driver.sql-jdbc.sync.common                            sql-jdbc.common
+    metabase.driver.sql-jdbc.sync.common                            sql-jdbc.sync.common
     metabase.driver.sql-jdbc.sync.describe-database                 sql-jdbc.describe-database
     metabase.driver.sql-jdbc.sync.describe-table                    sql-jdbc.describe-table
     metabase.driver.sql-jdbc.sync.interface                         sql-jdbc.sync.interface
@@ -401,6 +402,7 @@
   metabase.integrations.ldap/with-ldap-connection                                      clojure.core/fn
   metabase.mbql.schema.macros/defclause                                                clj-kondo.lint-as/def-catch-all
   metabase.models.collection-test/with-collection-in-location                          clojure.core/let
+  metabase.models.json-migration/def-json-migration                                    clj-kondo.lint-as/def-catch-all
   metabase.models.setting.multi-setting/define-multi-setting                           clojure.core/def
   metabase.models.setting/defsetting                                                   clj-kondo.lint-as/def-catch-all
   metabase.public-settings.premium-features/defenterprise                              clj-kondo.lint-as/def-catch-all
@@ -572,7 +574,7 @@
    metabase.query-processor-test.expressions-test/calculate-bird-scarcity                                                    hooks.metabase.query-processor-test.expressions-test/calculate-bird-scarcity
    metabase.query-processor-test.filter-test/count-with-filter-clause                                                        hooks.metabase.test.data/$ids
    metabase.query-processor.middleware.cache-test/with-mock-cache                                                            hooks.common/with-two-bindings
-   metabase.sample-database-test/with-temp-sample-database-db                                                                hooks.common/with-one-binding
+   metabase.sample-data-test/with-temp-sample-database-db                                                                    hooks.common/with-one-binding
    metabase.test.data.datasets/test-drivers                                                                                  hooks.common/do*
    metabase.test.data.users/with-group                                                                                       hooks.common/let-one-with-optional-value
    metabase.test.data/$ids                                                                                                   hooks.metabase.test.data/$ids

.github/actions/find-squashed-commit/action.yml

@@ -22,7 +22,7 @@ runs:
         COMMIT=$(env -i git log $BASE_REF --grep="(#$PULL_REQUEST_NUMBER)" --format="%H")
         echo "commit SHA $COMMIT"
 
-        echo "::set-output name=commit::$COMMIT"
+        echo "commit=$COMMIT" >> $GITHUB_OUTPUT
       id: find-squashed-commit
       shell: bash
       env:

.github/actions/test-driver/action.yml

@@ -0,0 +1,28 @@
+name: Test database driver
+inputs:
+  junit-name:
+    required: true
+    default: 'driver'
+  test-args:
+    required: false
+
+runs:
+  using: "composite"
+  steps:
+    - name: Prepare front-end environment
+      uses: ./.github/actions/prepare-frontend
+    - name: Prepare back-end environment
+      uses: ./.github/actions/prepare-backend
+    - name: Build static viz frontend
+      run: yarn build-static-viz
+      shell: bash
+    - name: Test database driver
+      run: clojure -X:dev:ci:ee:ee-dev:drivers:drivers-dev:test ${{ inputs.test-args }}
+      shell: bash
+    - name: Publish Test Report (JUnit)
+      uses: dorny/test-reporter@v1
+      if: always()
+      with:
+        path: 'target/junit/**/*_test.xml'
+        name: JUnit Test Report ${{ inputs.junit-name }}
+        reporter: java-junit

.github/workflows/auto-backport.yml

@@ -43,13 +43,13 @@ jobs:
           CONFLICTS=$(git ls-files -u | wc -l)
           if [ "$CONFLICTS" -gt 0 ]; then
             echo "Could not cherry pick because of a conflict"
-            echo "::set-output name=has-conflicts::true"
+            echo "has-conflicts=true" >> $GITHUB_OUTPUT
             git cherry-pick --abort
             git checkout master
             exit 0
           fi
 
-          echo "::set-output name=has-conflicts::false"
+          echo "has-conflicts=false" >> $GITHUB_OUTPUT
 
           git checkout master
           git push -u origin ${BACKPORT_BRANCH}
@@ -60,7 +60,7 @@ jobs:
 
           BACKPORT_PR_NUMBER=${BACKPORT_PR_URL##*/}
 
-          echo "::set-output name=backport_pr_number::$BACKPORT_PR_NUMBER"
+          echo "backport_pr_number=$BACKPORT_PR_NUMBER" >> $GITHUB_OUTPUT
         env:
           TARGET_BRANCH: ${{ steps.get_latest_release_branch.outputs.branch-name }}
           ORIGINAL_PULL_REQUEST_NUMBER: ${{ github.event.pull_request.number }}

.github/workflows/backend-skipped-checks.yml

@@ -4,12 +4,23 @@
 name: Backend
 
 on:
+  push:
+    branches:
+      - 'master'
+      - 'release-**'
+    paths:
+      - "docs/**"
+      - "**.md"
+      # frontend and E2E tests
+      - "**/frontend/test/**"
+      - "**/frontend/**.unit.*"
   pull_request:
     paths:
       - "docs/**"
       - "**.md"
-      - "frontend/test/**"
-      - "enterprise/frontend/test/**"
+      # frontend and E2E tests
+      - "**/frontend/test/**"
+      - "**/frontend/**.unit.*"
 
 jobs:
 

.github/workflows/backend.yml

@@ -5,15 +5,43 @@ on:
     branches:
       - 'master'
       - 'release-**'
+    paths-ignore:
+      - "docs/**"
+      - "**.md"
+      # frontend and E2E tests
+      - "**/frontend/test/**"
+      - "**/frontend/**.unit.*"
   pull_request:
+    types: [opened, synchronize, reopened, ready_for_review]
     paths-ignore:
       - "docs/**"
       - "**.md"
-      - "frontend/test/**"
-      - "enterprise/frontend/test/**"
+      # frontend and E2E tests
+      - "**/frontend/test/**"
+      - "**/frontend/**.unit.*"
 
 jobs:
 
+  be-linter-cloverage:
+    if: github.event.pull_request.draft == false
+    runs-on: ubuntu-20.04
+    timeout-minutes: 60
+    steps:
+    - uses: actions/checkout@v3
+    - name: Build static viz frontend
+      run: yarn build-static-viz
+    - name: Prepare back-end environment
+      uses: ./.github/actions/prepare-backend
+      with:
+        m2-cache-key: 'cloverage'
+    - name: Collect the test coverage
+      run: clojure -X:dev:ee:ee-dev:test:cloverage
+    - name: Upload coverage to codecov.io
+      uses: codecov/codecov-action@v2
+      with:
+        files: ./target/coverage/codecov.json
+        flags: back-end
+
   be-linter-clj-kondo:
     runs-on: ubuntu-20.04
     timeout-minutes: 10
@@ -65,6 +93,7 @@ jobs:
         /work/modules/drivers/presto-jdbc/test
 
   be-linter-eastwood:
+    if: github.event.pull_request.draft == false
     runs-on: ubuntu-20.04
     timeout-minutes: 20
     steps:
@@ -76,10 +105,41 @@ jobs:
     - run: clojure -X:dev:ee:ee-dev:drivers:drivers-dev:test:eastwood
       name: Run Eastwood linter
 
+  # Because it's not possible to conditionally run only `java-11-ee` test in the draft mode,
+  # we have to extract that job manually here. Backend developers have requested that this
+  # test runs at all times to give them an early warning sign is something is broken.
+  be-tests-java-11-ee-pre-check:
+    if: github.event.pull_request.draft == true
+    runs-on: ubuntu-20.04
+    name: be-tests-java-11-ee-pre-check
+    timeout-minutes: 25
+    steps:
+    - uses: actions/checkout@v3
+    - name: Prepare front-end environment
+      uses: ./.github/actions/prepare-frontend
+    - name: Prepare back-end environment
+      uses: ./.github/actions/prepare-backend
+
+    - run: yarn install --frozen-lockfile --prefer-offline
+    - name: Build static viz frontend
+      run: yarn build-static-viz
+
+    - name: Run tests
+      run: clojure -X:dev:ci:test:ee:ee-dev
+
+    - name: Publish Test Report (JUnit)
+      uses: dorny/test-reporter@v1
+      if: always()
+      with:
+        path: 'target/junit/**/*_test.xml'
+        name: JUnit Test Report be-tests-java-11-ee-pre-check
+        reporter: java-junit
+
   be-tests:
+    if: github.event.pull_request.draft == false
     runs-on: ubuntu-20.04
     name: be-tests-java-${{ matrix.java-version }}-${{ matrix.edition }}
-    timeout-minutes: 20
+    timeout-minutes: 25
     strategy:
       fail-fast: false
       matrix:
@@ -96,25 +156,30 @@ jobs:
     - name: Build static viz frontend
       run: yarn build-static-viz
 
-    - name: Compile Java source file(s)
-      run: clojure -X:deps prep
-    - name: Compile driver AOT namespaces
-      working-directory: modules/drivers
-      run: clojure -X:deps prep
-    - name: Fetch dependencies
-      run: clojure -P -X:dev:ci:ee:ee-dev:drivers:drivers-dev
-    - name: Fetch dependencies  (./bin/build/build-mb)
-      working-directory: bin/build-mb
-      run: clojure -P -M:test
-    - name: Fetch dependencies (./bin/build/build-drivers)
-      working-directory: bin/build-drivers
-      run: clojure -P -M:test
-
     - name: Run tests
       run: clojure -X:dev:ci:test:${{ matrix.edition }}:${{ matrix.edition }}-dev
+
     - name: Publish Test Report (JUnit)
-      uses: mikepenz/action-junit-report@v2
+      uses: dorny/test-reporter@v1
       if: always()
       with:
-        report_paths: 'target/junit/**/*_test.xml'
-        check_name: JUnit Test Report be-tests-java-${{ matrix.java-version }}-${{ matrix.edition }}
+        path: 'target/junit/**/*_test.xml'
+        name: JUnit Test Report be-tests-java-${{ matrix.java-version }}-${{ matrix.edition }}
+        reporter: java-junit
+
+  # checks that all the namespaces we actually ship can be compiled, without any dependencies that we don't ship (such
+  # as `:dev` dependencies). See #27009 for more context.
+  be-check:
+    if: github.event.pull_request.draft == false
+    runs-on: ubuntu-20.04
+    name: be-check-java-${{ matrix.java-version }}
+    timeout-minutes: 10
+    strategy:
+      matrix:
+        java-version: [11, 17, 19]
+    steps:
+      - uses: actions/checkout@v3
+      - name: Prepare backend
+        uses: ./.github/actions/prepare-backend
+      - name: Check namespaces
+        run: clojure -M:ee:drivers:check

.github/workflows/backport.yml

@@ -117,7 +117,7 @@ jobs:
 
               BACKPORT_PR_NUMBER=${BACKPORT_PR_URL##*/}
 
-              echo "::set-output name=backport_pr_number::$BACKPORT_PR_NUMBER"
+              echo "backport_pr_number=$BACKPORT_PR_NUMBER" >> $GITHUB_OUTPUT
               echo "New PR has been created"
           fi
         env: