Skip to content
This repository was archived by the owner on Jul 25, 2018. It is now read-only.

Compliance to latest spec (Issue #2) - #3

Open
nadameu wants to merge 1 commit into
fantasyland:masterfrom
nadameu:master
Open

Compliance to latest spec (Issue #2)#3
nadameu wants to merge 1 commit into
fantasyland:masterfrom
nadameu:master

Conversation

@nadameu

@nadameu nadameu commented Aug 17, 2017

Copy link
Copy Markdown

No description provided.

@davidchambers

davidchambers commented Aug 17, 2017

Copy link
Copy Markdown
Member

I think we should also set the fantasy-land dependency to "3.3.x" or "3.x.x".

@safareli

safareli commented Aug 18, 2017

Copy link
Copy Markdown
Member

and add fantasy-land/ prefixes

@davidchambers

davidchambers commented Aug 18, 2017

Copy link
Copy Markdown
Member

and add fantasy-land/ prefixes

I believe we're doing this already by using [ap] rather than .ap.

@nadameu nadameu mentioned this pull request Aug 18, 2017
Open
@safareli

safareli commented Aug 19, 2017

Copy link
Copy Markdown
Member

@davidchambers oh yes, didn't noticed.

@wojpawlik

wojpawlik commented Apr 26, 2018 •
edited
Loading

Copy link
Copy Markdown

This PR breaks tests for applicative interface:

Details 
io.js
✖ io - All (Applicative)

TypeError: f is not a function
    at (anonymous function) (D:\Wojciech\JS\fantasy-io\src\io.js:18:38)
    at Ctor.IO [as unsafePerform] (D:\Wojciech\JS\fantasy-io\src\io.js:13:21)
    at Ctor.IO [as unsafePerform] (D:\Wojciech\JS\fantasy-io\src\io.js:13:45)
    at run (D:\Wojciech\JS\fantasy-io\test\io.js:17:14)
    at D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\laws\applicative.js:16:25
    at D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\laws\applicative.js:77:33
    at rec (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-seqs\src\seq.js:34:38)
    at Ctor.Cons (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-seqs\src\seq.js:39:20)
    at Ctor.cata (D:\Wojciech\JS\fantasy-io\node_modules\daggy\daggy.js:134:40)
    at Ctor.Seq.fold (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-seqs\src\seq.js:37:17)
    at Ctor.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\laws\applicative.js:76:41)
    at Ctor.forAll (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\check.js:99:23)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\adapters\nodeunit.js:58:28)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16

✖ io - Identity (Applicative)

TypeError: f is not a function
    at (anonymous function) (D:\Wojciech\JS\fantasy-io\src\io.js:18:38)
    at Ctor.IO [as unsafePerform] (D:\Wojciech\JS\fantasy-io\src\io.js:13:21)
    at Ctor.IO [as unsafePerform] (D:\Wojciech\JS\fantasy-io\src\io.js:13:45)
    at run (D:\Wojciech\JS\fantasy-io\test\io.js:17:14)
    at Ctor.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\laws\applicative.js:16:25)
    at Ctor.forAll (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\check.js:99:23)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\adapters\nodeunit.js:58:28)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16
    at Object.exports.runTest (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:70:9)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:118:25
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:513:13
    at iterate (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:123:13)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:134:25
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:515:17

✖ io - Composition (Applicative)

TypeError: f is not a function
    at (anonymous function) (D:\Wojciech\JS\fantasy-io\src\io.js:18:38)
    at Ctor.IO [as unsafePerform] (D:\Wojciech\JS\fantasy-io\src\io.js:13:21)
    at Ctor.IO [as unsafePerform] (D:\Wojciech\JS\fantasy-io\src\io.js:13:45)
    at run (D:\Wojciech\JS\fantasy-io\test\io.js:17:14)
    at Ctor.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\laws\applicative.js:24:25)
    at Ctor.forAll (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\check.js:99:23)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\adapters\nodeunit.js:58:28)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16
    at Object.exports.runTest (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:70:9)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:118:25
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:513:13
    at iterate (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:123:13)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:134:25
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:515:17

✖ io - Homomorphism (Applicative)

TypeError: f is not a function
    at (anonymous function) (D:\Wojciech\JS\fantasy-io\src\io.js:18:38)
    at Ctor.IO [as unsafePerform] (D:\Wojciech\JS\fantasy-io\src\io.js:13:21)
    at Ctor.IO [as unsafePerform] (D:\Wojciech\JS\fantasy-io\src\io.js:13:45)
    at run (D:\Wojciech\JS\fantasy-io\test\io.js:17:14)
    at Ctor.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\laws\applicative.js:32:25)
    at Ctor.forAll (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\check.js:99:23)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\adapters\nodeunit.js:58:28)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16
    at Object.exports.runTest (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:70:9)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:118:25
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:513:13
    at iterate (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:123:13)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:134:25
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:515:17

✖ io - Interchange (Applicative)

TypeError: f is not a function
    at (anonymous function) (D:\Wojciech\JS\fantasy-io\src\io.js:18:38)
    at Ctor.IO [as unsafePerform] (D:\Wojciech\JS\fantasy-io\src\io.js:13:21)
    at Ctor.IO [as unsafePerform] (D:\Wojciech\JS\fantasy-io\src\io.js:13:45)
    at run (D:\Wojciech\JS\fantasy-io\test\io.js:17:14)
    at Ctor.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\laws\applicative.js:40:25)
    at Ctor.forAll (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\check.js:99:23)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\fantasy-check\src\adapters\nodeunit.js:58:28)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16)
    at Object.<anonymous> (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:236:16
    at Object.exports.runTest (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:70:9)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\lib\core.js:118:25
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:513:13
    at iterate (D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:123:13)
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:134:25
    at D:\Wojciech\JS\fantasy-io\node_modules\nodeunit\deps\async.js:515:17

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nadameu @davidchambers @safareli @wojpawlik