-
Notifications
You must be signed in to change notification settings - Fork 22
allow more options to be defined on datasets, mainly bar and color #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for the PR. The 3.0 branch was not complete and targeted on old beta version ChartJS. Upstream changed how plugins works(i.e. remove babel on compile), so more fix should be done to make it working on 3.0. |
I did a version that works with Chart.js 3, but it is far from ready to make a PR, it is pretty breaking and was tailored for our own use case. Will try to make a PR out of it. |
Another thing, this plugin should use date adapter instead of |
I made some changes to the 0.4.0 version of the timeline plugin, based on requirements we would like to implement with the timeline plugin. I would like to know what you think about that.
We are currently still on chartJs version 2.9.4 and this would be the required version for the modifications, too. (BTW, you've also started a branch for the 3.x version, is this already finished?)
This would require a version bump, because it may also breaks some existing use cases, mainly the use of colorFunction.
It would offer some new features, though, a new demo file dataset-colors.html shows some examples: