Skip to content

fix: Mismatch constructor parameters in DeployL2 script#486

Open
anzzyspeaksgit wants to merge 1 commit intofarcasterxyz:mainfrom
anzzyspeaksgit:fix/issue-415-farcaster
Open

fix: Mismatch constructor parameters in DeployL2 script#486
anzzyspeaksgit wants to merge 1 commit intofarcasterxyz:mainfrom
anzzyspeaksgit:fix/issue-415-farcaster

Conversation

@anzzyspeaksgit
Copy link
Copy Markdown

@anzzyspeaksgit anzzyspeaksgit commented Mar 16, 2026

Problem

As reported in #415, the KeyGateway constructor in src/KeyGateway.sol expects only two parameters (address _keyRegistry, address _initialOwner), but the deployment script DeployL2.s.sol was incorrectly passing three parameters (addrs.keyRegistry, addrs.storageRegistry, params.initialKeyRegistryOwner).

Solution

Removed the unused addrs.storageRegistry from the abi.encode call when verifying/deploying the KeyGateway in script/DeployL2.s.sol.

Testing

Successfully built the project using forge build to verify that it resolves any ABI mismatch issues.

Closes #415


PR-Codex overview

This PR focuses on modifying the parameters passed to the register function for the KeyGateway deployment, specifically reducing the number of arguments encoded.

Detailed summary

  • Removed addrs.storageRegistry from the parameters passed to abi.encode in the deployment of KeyGateway.
  • Updated the encoding to only include addrs.keyRegistry and params.initialKeyRegistryOwner.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Mismatch constructor parameters in script and contract

1 participant