fix: Mismatch constructor parameters in DeployL2 script#486
Open
anzzyspeaksgit wants to merge 1 commit intofarcasterxyz:mainfrom
Open
fix: Mismatch constructor parameters in DeployL2 script#486anzzyspeaksgit wants to merge 1 commit intofarcasterxyz:mainfrom
anzzyspeaksgit wants to merge 1 commit intofarcasterxyz:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As reported in #415, the
KeyGatewayconstructor insrc/KeyGateway.solexpects only two parameters (address _keyRegistry,address _initialOwner), but the deployment scriptDeployL2.s.solwas incorrectly passing three parameters (addrs.keyRegistry,addrs.storageRegistry,params.initialKeyRegistryOwner).Solution
Removed the unused
addrs.storageRegistryfrom theabi.encodecall when verifying/deploying theKeyGatewayinscript/DeployL2.s.sol.Testing
Successfully built the project using
forge buildto verify that it resolves any ABI mismatch issues.Closes #415
PR-Codex overview
This PR focuses on modifying the parameters passed to the
registerfunction for theKeyGatewaydeployment, specifically reducing the number of arguments encoded.Detailed summary
addrs.storageRegistryfrom the parameters passed toabi.encodein the deployment ofKeyGateway.addrs.keyRegistryandparams.initialKeyRegistryOwner.