Skip to content

Conversation

@aditiharini
Copy link
Contributor

@aditiharini aditiharini commented Sep 26, 2024

Contact info appears as "Object" in the logs because it isn't translated into a string prior to logging.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR focuses on enhancing the syncHealthJob by adding functionality to serialize contact information into a string format before logging, improving the clarity and usability of logs related to synchronization health.

Detailed summary

  • Added import for addressInfoFromGossip and addressInfoToString from ../../utils/p2p.js.
  • Introduced logic to extract rpcAddress from contactInfo.
  • Implemented error handling for addressInfo and return a string representation of the address if successful.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2024

🦋 Changeset detected

Latest commit: 7afa1b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/hubble Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 7:39pm

@aditiharini aditiharini added the t-chore Miscellaneous improvements label Sep 26, 2024
@aditiharini aditiharini changed the title chore: turn sync health contact info into string before logging fix: turn sync health contact info into string before logging Sep 26, 2024
@aditiharini aditiharini added t-bug A fix for a bug with the current system and removed t-chore Miscellaneous improvements labels Sep 26, 2024
@sds sds merged commit 8ce6169 into farcasterxyz:main Sep 26, 2024
7 checks passed
@codecov
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 34.68%. Comparing base (1880070) to head (7afa1b7).
Report is 371 commits behind head on main.

Files with missing lines Patch % Lines
apps/hubble/src/network/sync/syncHealthJob.ts 0.00% 6 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (1880070) and HEAD (7afa1b7). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (1880070) HEAD (7afa1b7)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2337       +/-   ##
===========================================
- Coverage   74.05%   34.68%   -39.38%     
===========================================
  Files          99      146       +47     
  Lines        9425    26013    +16588     
  Branches     2097     9119     +7022     
===========================================
+ Hits         6980     9022     +2042     
- Misses       2327    15238    +12911     
- Partials      118     1753     +1635     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-bug A fix for a bug with the current system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants