Skip to content

Conversation

@reject-i
Copy link

@reject-i reject-i commented May 25, 2025

Why is this change needed?

Fixed a logical error in the "fails with invalid signature" test where the private key was incorrectly used instead of the public key in the verifyMessageHashSignature function call.


PR-Codex overview

This PR updates the signature verification process in the ed25519 test by changing the key used from privateKey to publicKey, ensuring that the verification correctly utilizes the public key for validating message signatures.

Detailed summary

  • Changed the argument from privateKey to publicKey in the ed25519.verifyMessageHashSignature function call.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented May 25, 2025

⚠️ No Changeset found

Latest commit: 0bc5ef7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant