Skip to content

Conversation

@sanjayprabhu
Copy link
Contributor

@sanjayprabhu sanjayprabhu commented Aug 29, 2025

Why is this change needed?

Expose a function that calculates the expiry timestamp from just the block timestamp.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR focuses on updating the @farcaster/core and @farcaster/hub-nodejs packages to version 0.18.6 and 0.15.6 respectively, along with introducing a new function for calculating storage unit expiry timestamps.

Detailed summary

  • Updated @farcaster/core to version 0.18.6.
  • Updated @farcaster/hub-nodejs to version 0.15.6.
  • Added getStorageExpiryTimestampFromBlockTimestamp function in limits.ts.
  • Modified getStorageUnitExpiry to use the new expiry function.
  • Added tests for getStorageExpiryTimestampFromBlockTimestamp in limits.test.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@sanjayprabhu sanjayprabhu added the t-feat Add a new feature or protocol improvement label Aug 29, 2025
@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2025

⚠️ No Changeset found

Latest commit: e8b911a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 14.52%. Comparing base (1880070) to head (e8b911a).
⚠️ Report is 555 commits behind head on main.

Files with missing lines Patch % Lines
packages/core/src/limits.ts 85.71% 1 Missing ⚠️

❌ Your project status has failed because the head coverage (14.52%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2645       +/-   ##
===========================================
- Coverage   74.05%   14.52%   -59.54%     
===========================================
  Files          99       62       -37     
  Lines        9425    19170     +9745     
  Branches     2097     8159     +6062     
===========================================
- Hits         6980     2785     -4195     
- Misses       2327    13501    +11174     
- Partials      118     2884     +2766     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanjayprabhu sanjayprabhu merged commit 1204bd9 into farcasterxyz:main Aug 29, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-feat Add a new feature or protocol improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant