Skip to content

Conversation

@sanjayprabhu
Copy link
Contributor

@sanjayprabhu sanjayprabhu commented Sep 15, 2025

Why is this change needed?

Update client libs to support profile tokens

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR focuses on updating protobuf definitions to support new types, specifically adding profile tokens and enhancing event handling in the system.

Detailed summary

  • Removed job exports from packages/core/src/protobufs/index.ts.
  • Added PROFILE_TOKEN to UserDataType in multiple files.
  • Introduced validateProfileToken function in packages/core/src/validations.ts.
  • Added maxBlockEventSeqnum to various event-related interfaces.
  • Implemented SubmitBulkMessages RPC methods in packages/hub-nodejs/src/generated/rpc.ts.
  • Enhanced Block and BlockEvent structures to include transactions and events.
  • Added tests for profile token validation in packages/core/src/validations.test.ts.

The following files were skipped due to too many changes: packages/core/src/protobufs/generated/blocks.ts, packages/core/src/protobufs/generated/replication.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@sanjayprabhu sanjayprabhu added the t-feat Add a new feature or protocol improvement label Sep 15, 2025
@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2025

🦋 Changeset detected

Latest commit: d1d6cff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@farcaster/hub-nodejs Patch
@farcaster/hub-web Patch
@farcaster/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

❌ Patch coverage is 3.66667% with 578 lines in your changes missing coverage. Please review.
✅ Project coverage is 14.25%. Comparing base (1880070) to head (d1d6cff).
⚠️ Report is 556 commits behind head on main.

Files with missing lines Patch % Lines
packages/core/src/protobufs/generated/blocks.ts 1.62% 242 Missing ⚠️
packages/hub-nodejs/src/generated/blocks.ts 1.63% 172 Missing and 69 partials ⚠️
packages/core/src/protobufs/generated/sync_trie.ts 2.85% 34 Missing ⚠️
...s/core/src/protobufs/generated/request_response.ts 0.00% 14 Missing ⚠️
...kages/hub-nodejs/src/generated/request_response.ts 0.00% 9 Missing and 4 partials ⚠️
packages/core/src/protobufs/generated/hub_event.ts 0.00% 10 Missing ⚠️
packages/hub-nodejs/src/generated/hub_event.ts 0.00% 6 Missing and 4 partials ⚠️
packages/core/src/protobufs/generated/message.ts 0.00% 5 Missing ⚠️
packages/hub-nodejs/src/generated/message.ts 0.00% 5 Missing ⚠️
packages/hub-nodejs/src/generated/rpc.ts 0.00% 4 Missing ⚠️

❌ Your project status has failed because the head coverage (14.25%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2648       +/-   ##
===========================================
- Coverage   74.05%   14.25%   -59.81%     
===========================================
  Files          99       61       -38     
  Lines        9425    19652    +10227     
  Branches     2097     8208     +6111     
===========================================
- Hits         6980     2801     -4179     
- Misses       2327    14612    +12285     
- Partials      118     2239     +2121     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanjayprabhu sanjayprabhu merged commit e640c6c into farcasterxyz:main Sep 15, 2025
7 of 9 checks passed
@sanjayprabhu sanjayprabhu deleted the profile_token branch September 15, 2025 23:39
sanjayprabhu added a commit that referenced this pull request Sep 15, 2025
## Why is this change needed?

Release client versions for
#2648

## Merge Checklist

_Choose all relevant options below by adding an `x` now or at any time
before submitting for review_

- [x] PR title adheres to the [conventional
commits](https://www.conventionalcommits.org/en/v1.0.0/) standard
- [x] PR has a
[changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets)
- [x] PR has been tagged with a change label(s) (i.e. documentation,
feature, bugfix, or chore)
- [ ] PR includes
[documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs)
if necessary.


<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the version of the `@farcaster/core` package
and its dependencies, along with corresponding changelog updates to
reflect these changes.

### Detailed summary
- Updated `@farcaster/core` version from `0.18.6` to `0.18.7`.
- Added changelog entries for versions `0.18.7`, `0.11.5`, and `0.15.7`
with details on protobuf updates.
- Updated `@farcaster/core` dependency version in `packages/hub-web` and
`packages/hub-nodejs` from `0.18.6` to `0.18.7`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-feat Add a new feature or protocol improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant