Skip to content

Conversation

@Kewe63
Copy link

@Kewe63 Kewe63 commented Oct 14, 2025

upgrade

Why is this change needed?

Describe why this issue should be fixed and link to any relevant design docs, issues or other relevant items.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR updates the generate-protos.sh script to enhance its robustness and readability. It introduces better error handling, organizes the code structure, and clarifies the library selection process for generating protocol buffers.

Detailed summary

  • Added a shebang and set strict error handling with set -euo pipefail.
  • Defined PROTO_REPO, PROTO_PATH, and PROTO_REV as variables.
  • Introduced a cleanup step for the temporary directory before cloning.
  • Replaced multiple if statements with a case statement for library selection.
  • Enhanced error messaging for unrecognized library variables.
  • Improved formatting and readability of the Docker command.
  • Added a completion message after protobuf generation.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2025

⚠️ No Changeset found

Latest commit: cb0357d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant