fix: correct genesis parent_hash from vec![0,32] to vec![0;32] - #1019
Open
Sertug17 wants to merge 1 commit into
Open
fix: correct genesis parent_hash from vec![0,32] to vec![0;32]#1019Sertug17 wants to merge 1 commit into
Sertug17 wants to merge 1 commit into
Conversation
vec![0, 32] produces a 2-byte array [0x00, 0x20] due to Rust comma syntax. The genesis parent_hash must be 32 zero bytes to match the expected hash length throughout the codebase. This typo corrupts the genesis shard chunk hash chain from block 0 onward. Closes farcasterxyz#1017
|
@claude is attempting to deploy a commit to the Internal - Neynar Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #1017.
Problem
In
src/consensus/proposer.rs:173, the genesisparent_hashuses a comma instead of a semicolon:Rust syntax:
vec![0, 32]→ 2-element array[0x00, 0x20]vec![0; 32]→ 32-element array of zerosThe genesis
parent_hashmust be 32 zero bytes to match the hash length used throughout the codebase. This typo corrupts the genesis shard chunk hash chain from block 0 onward.Fix
Files Changed
src/consensus/proposer.rs—ShardProposer::create_new_shard_chunkCloses #1017