Skip to content

fix(provider): show terminal launch feedback immediately #3758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Amiyadesi wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −0
Open

fix(provider): show terminal launch feedback immediately #3758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,22 +773,33 @@ function App() {
};

const handleOpenTerminal = async (provider: Provider) => {
let openingToastId: string | number | undefined;

try {
const selectedDir = await settingsApi.pickDirectory();
if (!selectedDir) {
return;
}

openingToastId = toast.info(
t("provider.terminalOpening", {
defaultValue: "正在打开终端...",
}),
);
await providersApi.openTerminal(provider.id, activeApp, {
cwd: selectedDir,
});
toast.success(
t("provider.terminalOpened", {
defaultValue: "终端已打开",
}),
{ id: openingToastId },
);
} catch (error) {
console.error("[App] Failed to open terminal", error);
if (openingToastId !== undefined) {
toast.dismiss(openingToastId);
}
const errorMessage = extractErrorMessage(error);
toast.error(
t("provider.terminalOpenFailed", {
Expand Down
1 change: 1 addition & 0 deletions src/i18n/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@
"managedByHermes": "Hermes Managed",
"managedByHermesHint": "Defined in Hermes' providers: dict. Edit or remove it via Hermes Web UI.",
"openTerminal": "Open Terminal",
"terminalOpening": "Opening terminal...",
"terminalOpened": "Terminal opened",
"terminalOpenFailed": "Failed to open terminal",
"name": "Provider Name",
Expand Down
1 change: 1 addition & 0 deletions src/i18n/locales/ja.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@
"managedByHermes": "Hermes 管理",
"managedByHermesHint": "Hermes の providers: dict で定義されています。Hermes Web UI で編集または削除してください。",
"openTerminal": "ターミナルを開く",
"terminalOpening": "ターミナルを開いています...",
"terminalOpened": "ターミナルを開きました",
"terminalOpenFailed": "ターミナルを開けませんでした",
"name": "プロバイダー名",
Expand Down
1 change: 1 addition & 0 deletions src/i18n/locales/zh-TW.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@
"managedByHermes": "Hermes 託管",
"managedByHermesHint": "該專案定義於 Hermes 的 providers: dict，請在 Hermes Web UI 中編輯或刪除。",
"openTerminal": "開啟終端機",
"terminalOpening": "正在開啟終端機...",
"terminalOpened": "終端機已開啟",
"terminalOpenFailed": "開啟終端機失敗",
"name": "供應商名稱",
Expand Down
1 change: 1 addition & 0 deletions src/i18n/locales/zh.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@
"managedByHermes": "Hermes 托管",
"managedByHermesHint": "该条目定义在 Hermes 的 providers: dict，请在 Hermes Web UI 中编辑或删除。",
"openTerminal": "打开终端",
"terminalOpening": "正在打开终端...",
"terminalOpened": "终端已打开",
"terminalOpenFailed": "打开终端失败",
"name": "供应商名称",
Expand Down