feat: add image context model for Claude proxy#3771
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 633c7c18ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } else if (activeApp === "claude" && isProxyTakeover) { | ||
| await proxyApi.setProxyTakeoverForApp("claude", false); |
There was a problem hiding this comment.
Only disable Claude takeover for the provider being edited
When editing any Claude provider that does not have an imageModel, this branch turns off proxy takeover whenever isProxyTakeover is true, without checking whether the edited provider is the current provider. If the current provider still relies on an image model and the user edits an inactive text-only provider, Claude Code gets restored away from the proxy and image-context routing stops working for the active provider. The disable path should mirror the enable path by first confirming the updated/original id is the current provider.
Useful? React with 👍 / 👎.
|
Updated the PR to address the automated review and CI formatting failure.\n\nChanges in the follow-up commit:\n- Guard the Claude proxy takeover disable path so it only runs when the edited provider is the current provider, matching the enable path.\n- Added a focused useProviderActions test covering inactive text-only provider edits while Claude proxy takeover is active.\n- Ran Prettier on the files flagged by CI.\n\nVerified locally:\n- pnpm format:check\n- pnpm typecheck\n- pnpm exec vitest run tests/hooks/useProviderActions.test.tsx\n- pnpm test:unit |
Thanks for the pull request. When using AI to create pull requests and comments, please conduct a self-check first. Line breaks and escape characters were not properly handled. |
Summary
Details
Tests