Add criticism to the prompt template.#37
Open
swapneils wants to merge 1 commit intofarizrahman4u:mainfrom
Open
Add criticism to the prompt template.#37swapneils wants to merge 1 commit intofarizrahman4u:mainfrom
swapneils wants to merge 1 commit intofarizrahman4u:mainfrom
Conversation
Collaborator
|
Hey @swapneils! Thanks for the PR! We actually did have criticisms at first, but decided to remove it to keep things simpler. So let's hold off on this until we're sure it gives noticeably better results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure how useful this will be, but it seems like more complex plans or do_nothing stages may benefit from the AI generating criticism of its own plan, and it doesn't seem to harm performance judging from a few tests (though feel free to check yourselves, of course!).