Update log image version to not fail on missing docker labels #153
Conversation
|
If this PR introduces new features, bug fixes, or breaking changes in the NodeJs CLI, please consider updating the version number by running This is an automated reminder. If no version update is needed, you can safely ignore this comment. |
There was a problem hiding this comment.
Pull Request Overview
Updates the Docker image inspection functionality to handle cases where Docker images may be missing standard labels or metadata. The changes prevent failures when Docker image inspection cannot retrieve version or digest information.
- Modified
inspectDockerImageto return optional digest and version fields instead of throwing errors - Updated
logImageVersionto handle cases where image metadata is unavailable - Changed error handling from throwing exceptions to logging warnings when image inspection fails
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| airbyte-local-cli-nodejs/src/docker.ts | Modified inspectDockerImage to return optional fields and handle errors gracefully |
| airbyte-local-cli-nodejs/src/utils.ts | Updated logImageVersion to check for optional metadata before logging |
| airbyte-local-cli-nodejs/test/resources/test_config_file_src_only.json | Changed test image from "farosai/airbyte-example-source" to "gerrit" |
| logger.error(`Failed to inspect docker image: ${image}`); | ||
| throw error; | ||
| logger.warn(`Failed to inspect docker image '${image}': ${error.message ?? JSON.stringify(error)}`); | ||
| return {}; |
There was a problem hiding this comment.
Returning an empty object {} doesn't match the declared return type {digest?: string; version?: string}. Consider returning {digest: undefined, version: undefined} to be explicit about the optional fields.
| return {}; | |
| return {digest: undefined, version: undefined}; |
Copilot uses AI. Check for mistakes.
|
3 participants
This pull request updates the Docker image inspection and logging logic to be more robust against errors, and modifies a test resource configuration. The main improvements are better error handling when inspecting Docker images, safer logging of image details, and a test update to use a different image.
Docker image inspection and error handling:
inspectDockerImagefunction now returns an object with optionaldigestandversionfields instead of always requiring them, allowing for cases where inspection fails.Image version logging:
logImageVersionfunction now checks for bothdigestandversionbefore logging; if either is missing, it logs a warning instead of info.Test configuration update:
test_config_file_src_only.jsonnow uses thegerritimage instead offarosai/airbyte-example-source.