Skip to content

feat: set macOS deployment target to 15.0 #42#43

Open
beautyfree wants to merge 1 commit into
farouqaldori:mainfrom
beautyfree:main
Open

feat: set macOS deployment target to 15.0 #42#43
beautyfree wants to merge 1 commit into
farouqaldori:mainfrom
beautyfree:main

Conversation

@beautyfree

@beautyfree beautyfree commented Jan 29, 2026

Copy link
Copy Markdown

Set macOS deployment target to 15.0 and annotate relevant methods with @MainActor for improved concurrency handling

TaylorWatson pushed a commit to TaylorWatson/claude-island that referenced this pull request Feb 15, 2026
Adapted from upstream farouqaldori#43.
The @mainactor annotations from the upstream PR are already present
in our fork (class-level on AppDelegate and WindowManager).
pjh4993 pushed a commit to pjh4993/claude-island that referenced this pull request Feb 20, 2026
…ori#53)

* Fix sessions disappearing from UI shortly after hooks fire (farouqaldori#43)

Sessions were incorrectly transitioning to idle phase and being filtered
out of the display. This fix addresses two root causes:

1. HookEvent.determinePhase() now correctly maps idle_prompt notifications
   to waitingForInput instead of idle, and handles notification status
   explicitly as processing state.

2. UI filters in NotchView and NotchHeaderView no longer exclude idle
   sessions, allowing running Claude processes to remain visible with
   a dimmed indicator.

* Align sessionPhase with determinePhase() for notification handling

Ensures notification events trigger processing-related behavior like
starting the InterruptWatcherManager. Previously, sessionPhase fell
through to .idle for notification events while determinePhase() correctly
returned .processing.
raludi added a commit to raludi/claude-island that referenced this pull request Apr 2, 2026
…ldori#43, farouqaldori#51

- farouqaldori#37: SubagentStop sets status to "processing" instead of
  "waiting_for_input" — prevents notification sound when subagents complete
- farouqaldori#26: Add trailing padding to spinner/checkmark in collapsed notch to
  prevent clipping into the notch border
- farouqaldori#43: Lower macOS deployment target from 15.6 to 15.0 for broader
  compatibility. Add @mainactor to WindowManager for concurrency safety
- farouqaldori#51: Support Local.xcconfig for signing overrides in build script.
  Add Local.xcconfig to .gitignore

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Kel-Antony added a commit to Kel-Antony/claude-island that referenced this pull request Apr 9, 2026
…arouqaldori#43, farouqaldori#49, farouqaldori#52)

Always Allow (farouqaldori#52):
- Add permissionApprovedAlways event to SessionStore state machine
- Add autoApprovedTools: Set<String> to SessionState — approved tools
  are silently auto-approved on future requests within the same session
- Add Always (green) button to InlineApprovalButtons and ChatApprovalBar
- Island stays open when permissions are pending (can't dismiss by clicking away)

Keyboard shortcuts (farouqaldori#49):
- Add KeyCombo model with Codable + displayString support
- Add KeyboardShortcutHandler using Carbon RegisterEventHotKey for
  true system-wide hotkeys (work regardless of focused app)
  - ⌘⇧Y = Approve, ⌘⇧N = Deny, ⌘⇧↓/↑ = cycle between pending sessions
- Add shortcut settings to AppSettings (UserDefaults backed)
- Add selectedPendingSessionId + hasPendingPermissions to NotchViewModel
- Show amber left-edge indicator on the keyboard-selected pending row
- Instances panel height is now dynamic (52pt per row, clamped 120–400pt)

Deployment target (farouqaldori#43):
- Lower MACOSX_DEPLOYMENT_TARGET from 15.6 → 15.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant