Fix hide_apps #627
Open
Fix hide_apps #627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the case sensitivity issue introduced in PR #605, which caused the hide_apps setting to stop working correctly.
Changes Made
Applies the .lower() method to the hide_apps comparison in the get_side_menu method to ensure consistent case matching.
This adjustment is made later in the process to preserve the group label's original case that appears to be the reason for the initial removal.
Why This is Needed
Without this fix, users who rely on hide_apps may find that their configurations no longer work if their app names contain uppercase letters.
Testing
Manually tested by configuring hide_apps with both uppercase and lowercase app names.
Confirmed that the group labels retain their original casing.
Impact
This change should only affect the case sensitivity of hide_apps and should not impact other functionalities. No breaking changes expected.