replace assert() with error handling, fix memory leaks and correctness bugs - #93
Open
rafaelvanoni wants to merge 12 commits into
Open
replace assert() with error handling, fix memory leaks and correctness bugs#93rafaelvanoni wants to merge 12 commits into
rafaelvanoni wants to merge 12 commits into
Conversation
rafaelvanoni
force-pushed
the
tmerged-investigation
branch
2 times, most recently
from
August 14, 2026 08:57
7e2172f to
3524c8b
Compare
rafaelvanoni
force-pushed
the
tmerged-investigation
branch
from
August 14, 2026 09:11
3524c8b to
da48c4e
Compare
rafaelvanoni
changed the title
rafaelvanoni
marked this pull request as ready for review
August 18, 2026 22:01
added 7 commits
August 18, 2026 15:12
rafaelvanoni
force-pushed
the
tmerged-investigation
branch
2 times, most recently
from
August 19, 2026 22:14
4904878 to
510fce0
Compare
rafaelvanoni
force-pushed
the
tmerged-investigation
branch
from
August 19, 2026 22:21
510fce0 to
bdfbc95
Compare
edmonds
reviewed
Aug 19, 2026
| fd = open(fname, O_RDONLY); | ||
| if (fd < 0) | ||
| if (fd < 0) { | ||
| fprintf(stderr, "%s: ERROR: failed to open(2) '%s': %s\n", __func__, fname, strerror(errno)); |
Contributor
There was a problem hiding this comment.
This is library code. Libraries should not be writing to stdout/stderr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes came from the tmerged investigation and the intention to harden
mtbl_mergeand keep it from silently failing.