feat!: add an unified CodecToSlice<In, Out = In> API#58
Merged
Conversation
CommanderStorm
requested review from
Copilot,
jjcfrancisco and
nyurik
and removed request for
Copilot,
jjcfrancisco and
nyurik
February 14, 2026 13:25
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
nyurik
approved these changes
Feb 14, 2026
CommanderStorm
added a commit
that referenced
this pull request
Feb 14, 2026
This is stacked on top of #58 --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new trait
CodecToSlice<In, Out = In>:Here are the alternatives I have considered:
bytesorCursorbased API does not work for cpp&mut Vecdoes not work for being zero abstraction and likely not work for cpp (because of what users would expect)Con: may alocate
Not sure if this would be better
I chose
CodecToSlicesince this way we can migrate step by step and still have the "good name"Codecfor the final trait that we can settle on, once we have a better idea what kind of API we really need.