chore(ci): Ensure installing SIMDe is not necessary#64
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the CI workflow by removing manual SIMDe installation steps for macOS, following the changes in PR #63 that made SIMDe installation automatic via CMake. The build system now fetches and configures SIMDe automatically for aarch64 platforms, eliminating the need for platform-specific CI setup.
Changes:
- Removed
brew install simdestep for macOS runners - Removed macOS-specific CXXFLAGS and CFLAGS environment variable configuration
- Consolidated platform-specific test steps into a single unified
just ci-testcommand
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #63, installing SIMDe should not be necessary. So, this pull request simplifies the CI settings by removing
brew install simde.