chore: 2024 edition, disable vsencoding_codec, minor cleanups#66
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
nyurik
enabled auto-merge (squash)
March 4, 2026 07:10
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the crate to Rust 2024 edition and performs a set of small cleanups (import ordering/rustfmt, lint scoping, and minor API annotations) across tests, fuzz targets, benches, and the Rust/C++ codec wrappers.
Changes:
- Bump crate
editionto2024and adjust lint configuration inCargo.toml. - Add
#[must_use]annotations to several constructors and test helpers; scopedead_codesuppression totests/common.rs. - Apply rustfmt/import reordering and minor formatting tweaks across tests/fuzz/benches; comment out the leaky
vsencoding_codecFFI declaration.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
Cargo.toml |
Bumps edition to 2024 and removes some lint overrides. |
build.rs |
Splits grouped imports (formatting cleanup). |
src/rust/mod.rs |
Reorders re-exports (formatting cleanup). |
src/rust/integer_compression/codec.rs |
Reorders imports. |
src/rust/integer_compression/variable_byte.rs |
Adds #[must_use] to VariableByte::new. |
src/rust/integer_compression/just_copy.rs |
Adds #[must_use] to JustCopy::new. |
src/rust/integer_compression/fastpfor.rs |
Adds #[must_use] to FastPFOR::new. |
src/rust/integer_compression/differential/mod.rs |
Adds #[must_use] to Delta::new. |
src/cpp/mod.rs |
Comments out vsencoding_codec in the CXX bridge (known leak). |
tests/common.rs |
Adds dead_code allow locally and #[must_use] on helpers; minor formatting. |
tests/basic_tests.rs |
Import ordering tweak. |
benches/fastpfor_benchmark.rs |
Import ordering tweak. |
fuzz/fuzz_targets/common.rs |
Consolidates imports. |
fuzz/fuzz_targets/rust_decompress_oracle.rs |
Import ordering tweak. |
fuzz/fuzz_targets/rust_compress_oracle.rs |
Formats long for loop header for readability. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CommanderStorm
approved these changes
Mar 4, 2026
CommanderStorm
left a comment
Collaborator
There was a problem hiding this comment.
Commenting out Vs encoding would benefit from a code comment why it is commented out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.