Skip to content

chore: 2024 edition, disable vsencoding_codec, minor cleanups#66

Merged
nyurik merged 1 commit into
fast-pack:mainfrom
nyurik:cleanups
Mar 4, 2026
Merged

chore: 2024 edition, disable vsencoding_codec, minor cleanups#66
nyurik merged 1 commit into
fast-pack:mainfrom
nyurik:cleanups

Conversation

@nyurik

@nyurik nyurik commented Mar 4, 2026

Copy link
Copy Markdown
Member

No description provided.

@nyurik
nyurik requested review from CommanderStorm and Copilot March 4, 2026 07:08
@nyurik nyurik changed the title chore: bump to 2024 edition, minor cleanups chore: 2024 edition, disable vsencoding_codec, minor cleanups Mar 4, 2026
@codecov

codecov Bot commented Mar 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@nyurik
nyurik enabled auto-merge (squash) March 4, 2026 07:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the crate to Rust 2024 edition and performs a set of small cleanups (import ordering/rustfmt, lint scoping, and minor API annotations) across tests, fuzz targets, benches, and the Rust/C++ codec wrappers.

Changes:

  • Bump crate edition to 2024 and adjust lint configuration in Cargo.toml.
  • Add #[must_use] annotations to several constructors and test helpers; scope dead_code suppression to tests/common.rs.
  • Apply rustfmt/import reordering and minor formatting tweaks across tests/fuzz/benches; comment out the leaky vsencoding_codec FFI declaration.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Cargo.toml Bumps edition to 2024 and removes some lint overrides.
build.rs Splits grouped imports (formatting cleanup).
src/rust/mod.rs Reorders re-exports (formatting cleanup).
src/rust/integer_compression/codec.rs Reorders imports.
src/rust/integer_compression/variable_byte.rs Adds #[must_use] to VariableByte::new.
src/rust/integer_compression/just_copy.rs Adds #[must_use] to JustCopy::new.
src/rust/integer_compression/fastpfor.rs Adds #[must_use] to FastPFOR::new.
src/rust/integer_compression/differential/mod.rs Adds #[must_use] to Delta::new.
src/cpp/mod.rs Comments out vsencoding_codec in the CXX bridge (known leak).
tests/common.rs Adds dead_code allow locally and #[must_use] on helpers; minor formatting.
tests/basic_tests.rs Import ordering tweak.
benches/fastpfor_benchmark.rs Import ordering tweak.
fuzz/fuzz_targets/common.rs Consolidates imports.
fuzz/fuzz_targets/rust_decompress_oracle.rs Import ordering tweak.
fuzz/fuzz_targets/rust_compress_oracle.rs Formats long for loop header for readability.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/rust/integer_compression/fastpfor.rs

@CommanderStorm CommanderStorm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting out Vs encoding would benefit from a code comment why it is commented out

@nyurik
nyurik merged commit 75c2f18 into fast-pack:main Mar 4, 2026
16 checks passed
@nyurik
nyurik deleted the cleanups branch March 4, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants