Skip to content

chore: rename c++ codecs and use portable C++ submodule#76

Merged
nyurik merged 2 commits into
fast-pack:mainfrom
nyurik:rename-bump
Mar 22, 2026
Merged

chore: rename c++ codecs and use portable C++ submodule#76
nyurik merged 2 commits into
fast-pack:mainfrom
nyurik:rename-bump

Conversation

@nyurik

@nyurik nyurik commented Mar 22, 2026

Copy link
Copy Markdown
Member
  • no code changes - just rename all C++ codecs to Cpp* without the Codec suffix.
  • bump C++ dependency to the latest main - i think this is the reason the last release didn't handle portable C++ properly

@nyurik
nyurik requested review from CommanderStorm and Copilot and removed request for Copilot March 22, 2026 20:44
@codecov

codecov Bot commented Mar 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renames the Rust-side C++ codec wrapper types to the Cpp* naming scheme (dropping the *Codec suffix) and updates the vendored C++ submodule revision to improve portability.

Changes:

  • Renamed C++ codec wrapper types throughout tests, benchmarks, fuzzers, and documentation to Cpp*.
  • Updated cpp git submodule to a newer commit.
  • Minor tooling tweak in justfile to use pushd/popd during formatting.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
tests/cpp_compat_tests.rs Updates tests to use the renamed Cpp* codec types.
tests/benchmark_smoke.rs Updates smoke tests to construct CppFastPFor128.
src/cpp/tests.rs Updates macro-driven C++ codec tests to the new Cpp* names and refactors macro patterns.
src/cpp/codecs.rs Renames exported wrapper types to Cpp* and updates internal tests/docs accordingly.
justfile Uses pushd/popd instead of cd in the fmt recipe.
fuzz/fuzz_targets/rust_decompress_oracle.rs Switches fuzz target to instantiate Cpp* codecs.
fuzz/fuzz_targets/rust_compress_oracle.rs Switches fuzz target to instantiate Cpp* codecs.
fuzz/fuzz_targets/common.rs Updates codec factory to return Cpp* codec instances.
cpp Bumps the C++ submodule commit (portable C++ update).
benches/fastpfor_benchmark.rs Updates benchmarks to use CppFastPFor128.
benches/bench_utils.rs Updates helpers to accept CppFastPFor128.
README.md Updates docs example to use CppSimdFastPFor128.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/benchmark_smoke.rs
Comment thread benches/fastpfor_benchmark.rs
Comment thread benches/bench_utils.rs
Comment thread src/cpp/tests.rs
Comment thread src/cpp/tests.rs
Comment thread src/cpp/codecs.rs Outdated
Comment thread justfile
Comment thread justfile
@nyurik
nyurik merged commit bf5c165 into fast-pack:main Mar 22, 2026
13 checks passed
@nyurik
nyurik deleted the rename-bump branch March 22, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants