chore: rename c++ codecs and use portable C++ submodule#76
Merged
Conversation
nyurik
requested review from
CommanderStorm and
Copilot
and removed request for
Copilot
March 22, 2026 20:44
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
Renames the Rust-side C++ codec wrapper types to the Cpp* naming scheme (dropping the *Codec suffix) and updates the vendored C++ submodule revision to improve portability.
Changes:
- Renamed C++ codec wrapper types throughout tests, benchmarks, fuzzers, and documentation to
Cpp*. - Updated
cppgit submodule to a newer commit. - Minor tooling tweak in
justfileto usepushd/popdduring formatting.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/cpp_compat_tests.rs | Updates tests to use the renamed Cpp* codec types. |
| tests/benchmark_smoke.rs | Updates smoke tests to construct CppFastPFor128. |
| src/cpp/tests.rs | Updates macro-driven C++ codec tests to the new Cpp* names and refactors macro patterns. |
| src/cpp/codecs.rs | Renames exported wrapper types to Cpp* and updates internal tests/docs accordingly. |
| justfile | Uses pushd/popd instead of cd in the fmt recipe. |
| fuzz/fuzz_targets/rust_decompress_oracle.rs | Switches fuzz target to instantiate Cpp* codecs. |
| fuzz/fuzz_targets/rust_compress_oracle.rs | Switches fuzz target to instantiate Cpp* codecs. |
| fuzz/fuzz_targets/common.rs | Updates codec factory to return Cpp* codec instances. |
| cpp | Bumps the C++ submodule commit (portable C++ update). |
| benches/fastpfor_benchmark.rs | Updates benchmarks to use CppFastPFor128. |
| benches/bench_utils.rs | Updates helpers to accept CppFastPFor128. |
| README.md | Updates docs example to use CppSimdFastPFor128. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cpp*without theCodecsuffix.