Conversation
|
Hey @dwradcliffe , just wanted to check in. Did you want me to review your PR, or is it still under development? |
backend/pkg/database/gorm_common.go
Outdated
| if result.Error != nil { | ||
| return result.Error | ||
| } | ||
| // Update User Permissions |
There was a problem hiding this comment.
ideally this would all be handed by the GORM Association logic & hooks
There was a problem hiding this comment.
Updated, please take a look
backend/pkg/models/user.go
Outdated
| Picture string `json:"picture"` | ||
| Email string `json:"email"` | ||
| Role pkg.UserRole `json:"role"` | ||
| Permissions map[string]map[string]bool `json:"permissions" gorm:"-:all"` |
There was a problem hiding this comment.
can we use GORM references for this - https://gorm.io/docs/has_many.html#Override-References
There was a problem hiding this comment.
I'm not 100% sure what you're suggesting here. I'm using a different format for the api so that it's easier to handle the frontend concerns without leaking the database structure into the frontend. I think the current version is a good compromise but please take a look.
dwradcliffe
force-pushed
the
user_acls
branch
2 times, most recently
from
66b1310 to
a9bf9b2
Compare
|
Bump. @AnalogJ - looks like this one is needs more clarity from you on what your suggesting "can we use GORM references". Can we go with what @dwradcliffe has done for now, or is this a blocking issue? |
3 participants
Part of #57
This adds the ability for an admin user to set permissions for each user. This does not allow these permissions to be used, that will be in the next PR.