Skip to content

Link to latest Tier1 and JIT stats #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Conversation

mdboom
Copy link
Contributor

@mdboom mdboom commented Mar 11, 2025

No description provided.

@mdboom mdboom requested a review from Copilot March 11, 2025 16:52
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the logic for retrieving and displaying the most recent pystats by iterating over multiple flag combinations instead of returning a single result.

  • Refactored get_most_recent_pystats() to yield tuples of flags and the corresponding most recent result.
  • Adjusted generate_index() to iterate over these tuples and display a formatted link for each.
Comments suppressed due to low confidence (2)

bench_runner/scripts/generate_results.py:176

  • [nitpick] Using an empty list within the flags tuple can be ambiguous; consider using an explicit label (e.g., 'default') to clarify its meaning.
for flags in ([], ["PYTHON_UOPS"], ["JIT"]):

bench_runner/scripts/generate_results.py:209

  • [nitpick] If flags is empty, the join will produce an empty string, which might lead to a confusing label. Consider providing a default descriptor when no flags are present.
f"Most recent {','.join(flags)} pystats on main ({result.cpython_hash})",

@mdboom mdboom merged commit 087b16c into main Mar 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant