Add support for passing extra flags to Python's configure via env vars #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which can override earlier passed flags (like --enable-optimizations). Add a description of env vars to the sample bench_runner.toml, and include a windows runner to show BUILD_DEST being set.
mdboom
approved these changes
Apr 7, 2025
|
Note to self: This will need to be ported to #382. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for passing extra flags to Python's configure via env vars, which can override earlier passed flags (like --enable-optimizations).
Add a description of env vars to the sample bench_runner.toml, describe a few common pitfalls with a few specific ones, and include a windows runner to show BUILD_DEST being set.