Add support for explicit per-runner CPU affinity #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PYPERF_CPU_AFFINITY) is set, as well.
mdboom
approved these changes
Apr 7, 2025
|
Note to self: This will need to be ported to #382. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for explicit CPU affinity via a runner-configurable environment variable (either in the runner configuration, or in the environment of the GHA runner itself). This is useful when running on a host that can't use isolated CPUs (which pyperf automatically detects).
Also undo the changes made by
pyperf system tuneafter the benchmark run. (The system is generally more performant without benchmark tuning, so this matters for other users of the host and for the compile time on a dedicated runner.)