Skip to content

Avoid cross-filesystem renames in svg generation #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025
Merged

Avoid cross-filesystem renames in svg generation #392

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37800ca
In svg generation, make temporary files in the output directory, to a…
Yhg1s Mar 31, 2025
33868b3
Reformat.
Yhg1s Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion bench_runner/plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,9 @@ class Options:
plt.close("all")

if output_filename.suffix == ".svg":
with tempfile.NamedTemporaryFile(delete=False) as tmp:
with tempfile.NamedTemporaryFile(
dir=output_filename.parent, delete=False
) as tmp:
with open(output_filename) as fd:
scour.start(Options(), fd, tmp)
output_filename.unlink()
Expand Down