-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct fastify version on plugin genration #804
fix: correct fastify version on plugin genration #804
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Could you add a test to compare the repo's package.json > fastify
with the one in the template?
I'm sure we will miss it in the next major release if we don't add a test now 😔
Yes for sure, I will provide it as soon as possible. I am already working on it |
Thank you, @Eomm, as soon as possible, I will provide the code with your suggestion. I'll try within today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR aims to fix the error that occurs when using the generate-plugin command, which copies the template with version ^4.0 instead of ^5.0.0
I've already opened an issue: #803
Checklist
npm run test
andnpm run benchmark
and the Code of conduct