Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct fastify version on plugin genration #804

Merged

Conversation

gafreax
Copy link
Contributor

@gafreax gafreax commented Mar 15, 2025

This PR aims to fix the error that occurs when using the generate-plugin command, which copies the template with version ^4.0 instead of ^5.0.0
I've already opened an issue: #803

Checklist

Open Source Saturday

Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Could you add a test to compare the repo's package.json > fastify with the one in the template?
I'm sure we will miss it in the next major release if we don't add a test now 😔

@Eomm Eomm linked an issue Mar 16, 2025 that may be closed by this pull request
2 tasks
@gafreax
Copy link
Contributor Author

gafreax commented Mar 16, 2025

Yes for sure, I will provide it as soon as possible. I am already working on it

@gafreax
Copy link
Contributor Author

gafreax commented Mar 16, 2025

Thank you, @Eomm, as soon as possible, I will provide the code with your suggestion. I'll try within today

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eomm Eomm merged commit 09ab76d into fastify:main Mar 29, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate-plugin template uses incorrect Fastify version
3 participants