Skip to content

Remove redundant check #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Uzlopak merged 4 commits into from
Sep 11, 2025
Merged

Remove redundant check #895

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6142e3e
Remove redundant check
fedyk Sep 9, 2025
1a1dcd2
add tests
fedyk Sep 9, 2025
ce7fa27
fix tests
fedyk Sep 10, 2025
d450fc3
fix test
Uzlopak Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/util/should-route-hide.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ function shouldRouteHide (schema, opts) {
}

if (tags.includes(hiddenTag)) {
return schema.tags.includes(hiddenTag)
return true
}

return false
Expand Down
19 changes: 19 additions & 0 deletions test/util.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ const { test } = require('node:test')
const { formatParamUrl } = require('../lib/util/format-param-url')
const { hasParams, matchParams } = require('../lib/util/match-params')
const { generateParamsSchema, paramName } = require('../lib/util/generate-params-schema')
const { shouldRouteHide } = require('../lib/util/should-route-hide')

const cases = [
['/example/:userId', '/example/{userId}'],
Expand Down Expand Up @@ -141,3 +142,21 @@ test('paramName function', async (t) => {
t.assert.strictEqual(result, 'userId')
})
})

test('shouldRouteHide', async (t) => {
await t.test('shouldRouteHide should return true for hidden route', () => {
t.assert.ok(shouldRouteHide({ hide: true }, {}))
})

await t.test('shouldRouteHide should return true for hideUntagged', () => {
t.assert.ok(shouldRouteHide({ tags: [] }, { hideUntagged: true }))
})

await t.test('shouldRouteHide should return true for hiddenTag', () => {
t.assert.ok(shouldRouteHide({ tags: ['x-test'] }, { hiddenTag: 'x-test' }))
})

await t.test('shouldRouteHide should return false for non hidden route', () => {
t.assert.equal(shouldRouteHide({}, {}), false)
})
})
Loading