Add Typescript support #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners
reviewed
Jan 6, 2025
|
If you want to close the PR feel free to do it, I don't rawdog javascript anymore so I would not use it without the typescript types, I just opened the PR in case you want to reuse my code, now I install the fork of my git repo |
This is an inappropriate comment and against our code of conduct https://github.com/fastify/.github/blob/d7108ea460bbf3710ea1c786fb75f57331d28707/CODE_OF_CONDUCT.md#our-standards.
You're welcome to contribute whatever types files are appropriate. But converting the project to a different language without prior discussion and agreement is not acceptable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.