-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(.github): pin actions to commit-hash #153
base: main
Are you sure you want to change the base?
Conversation
@@ -103,7 +103,7 @@ jobs: | |||
pull-requests: write | |||
steps: | |||
- name: Comment PR | |||
uses: thollander/actions-comment-pull-request@v3 | |||
uses: thollander/actions-comment-pull-request@65f9e5c9a1f2cd378bd74b2e057c9736982a8e74 # v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, this one is good, but we don't need to use hashes on the GitHub owned actions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did consider not using hashes for GitHub's official actions as they should (hopefully) be more secure than third-party actions, but official actions aren't immune from being compromised, so pinned them just to help me sleep better at night. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not immune. But highly unlikely. I think the maintenance cost is too high to use hashes on GH maintained actions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependabot is active in this repo so it'll open PRs for updates for us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW dependabot and renovatebot automatically update those dependencies in the same way as git tags.
That's fine as this repo doesn't automerge dependabot updates, so someone will now need to manually review and merge, adding an extra layer of security. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm if @jsumners is convinced, I feel like this trades convenience for security
After what has been happening with tj-actions/changed-files over the past week this is probably a sensible idea.
@RafaelGSS even wrote about it a while back!
Checklist
and the Code of conduct