Skip to content

CDTOOL-1105 feat(ngwaf/v1/signals): moves signals up to the base level and adds support for account level signals #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anthony-gomez-fastly merged 3 commits into from
Jul 21, 2025
Merged

CDTOOL-1105 feat(ngwaf/v1/signals): moves signals up to the base level and adds support for account level signals #722

anthony-gomez-fastly merged 3 commits into from
Jul 21, 2025

Conversation

@anthony-gomez-fastly
Copy link
Contributor

@anthony-gomez-fastly anthony-gomez-fastly commented Jul 16, 2025 •
edited
Loading

BREAKING
All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

anthony-gomez-fastly
anthony-gomez-fastly commented Jul 17, 2025
View reviewed changes
@anthony-gomez-fastly anthony-gomez-fastly marked this pull request as ready for review July 21, 2025 14:52
@anthony-gomez-fastly anthony-gomez-fastly requested a review from a team as a code owner July 21, 2025 14:52
rcaril
rcaril approved these changes Jul 21, 2025
View reviewed changes
Copy link
Contributor

@rcaril rcaril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anthony-gomez-fastly anthony-gomez-fastly merged commit a5e25e5 into main Jul 21, 2025
7 checks passed
@anthony-gomez-fastly anthony-gomez-fastly deleted the CDTOOL-1105 branch July 21, 2025 15:21
@rcaril rcaril restored the CDTOOL-1105 branch August 12, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kpfleming kpfleming kpfleming approved these changes

@rcaril rcaril rcaril approved these changes

@philippschulte philippschulte Awaiting requested review from philippschulte

Assignees

No one assigned

Labels

breaking-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anthony-gomez-fastly @kpfleming @rcaril