Skip to content

Conversation

@anthony-gomez-fastly
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

@anthony-gomez-fastly anthony-gomez-fastly marked this pull request as ready for review July 29, 2025 15:12
@anthony-gomez-fastly anthony-gomez-fastly requested a review from a team as a code owner July 29, 2025 15:12
Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Could you please provide some context on why these changes are necessary? It's currently unclear to me what problem they're solving. Some concrete examples or use cases would be helpful.

To my knowledge, we typically don’t omit fields from response structures. If that’s not the case, could you point to other resources in the codebase that follow a similar pattern for comparison?

I also noticed that you’re changing the types of some fields, which could introduce a breaking change. If there's a way to avoid that—especially right now—that would be preferable.

Lastly, keep in mind that Go 1.24 introduces the omitzero struct tag, which might be relevant for what you're trying to achieve.

Thanks!

@anthony-gomez-fastly anthony-gomez-fastly deleted the change-optional-fields-on-workspaces branch July 30, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants