-
Notifications
You must be signed in to change notification settings - Fork 129
feat(domainmanagement): Adds support for domain-management/v1/domains endpoints #726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
gschorkopf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks accurate to me, but I'll let others weigh in
kpfleming
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need a CHANGELOG entry although it doesn't have to be marked as breaking since this product is still in beta.
The TestClient_Domain test failed, that will need to be corrected.
…gement/v1/domains endpoints
97c02fe to
f8a9dec
Compare
f8a9dec to
95c85d9
Compare
kpfleming
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to go - however we won't be able to upgrade the CLI to go-fastly version 11.x until some context related work is done there first. I will try to work on that today.
|
@kpfleming I see the CLI PR for updating to go-fastly v11.x has been completed. So I'm guessing this PR is safe to merge now? |
|
It was safe to merge before that too :-) |
|
Thanks @kpfleming when is the next release cycle for go-fastly expected? |
|
Ah, I see from the README...
Damn, I just missed a release 😅 |
|
There will probably be one fairly soon, as some 'fast follow' work for the Security API is in flight right now. |
All Submissions:
New Feature Submissions:
Changes to Core Features:
Updates UDM routes to use new
/domain-management/v1/domainsAPI endpoints instead of/domains/v1. Renames/Reorganizesdomains/v1files to follow new structure as well