Skip to content

CDTOOL-1034 add test coverage for compute services #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anthony-gomez-fastly merged 4 commits into from
Sep 9, 2025
Merged

CDTOOL-1034 add test coverage for compute services #750

anthony-gomez-fastly merged 4 commits into from
Sep 9, 2025

Conversation

@anthony-gomez-fastly
Copy link
Contributor

@anthony-gomez-fastly anthony-gomez-fastly commented Sep 8, 2025 •
edited
Loading

Change summary

Added test cases for compute services for the below items. Mostly done by using our testing compute service XsjdElScZGjmfCcTwsYRC1

  • Backends
  • Health Checks
  • Logging
  • Product Enablement/Configuration (for products which are supported on both types of services)
  • Purge
  • Service Details
  • Service Version
  • TLS Subscriptions

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

@anthony-gomez-fastly anthony-gomez-fastly added the Skip-Changelog Do not check for changelog diff label Sep 8, 2025
@anthony-gomez-fastly anthony-gomez-fastly marked this pull request as ready for review September 8, 2025 17:26
@anthony-gomez-fastly anthony-gomez-fastly requested a review from a team as a code owner September 8, 2025 17:26
rcaril
rcaril reviewed Sep 8, 2025
View reviewed changes
rcaril
rcaril reviewed Sep 8, 2025
View reviewed changes
rcaril
rcaril approved these changes Sep 9, 2025
View reviewed changes
Copy link
Contributor

@rcaril rcaril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid and thoughtful changes

@anthony-gomez-fastly anthony-gomez-fastly merged commit c8a8c76 into main Sep 9, 2025
7 checks passed
@anthony-gomez-fastly anthony-gomez-fastly deleted the CDTOOL-1034-compute-test-coverage branch September 9, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rcaril rcaril rcaril approved these changes

@kpfleming kpfleming Awaiting requested review from kpfleming

Assignees

No one assigned

Labels

Skip-Changelog Do not check for changelog diff

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anthony-gomez-fastly @rcaril