Skip to content

Conversation

@kpfleming
Copy link
Contributor

Change summary

Add support for enabling and disabling the API Discovery product.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?
==> Downloading Go module
==> Tidying module
==> Installing golangci-lint v2.4.0
==> Running golangci-lint fmt
==> Checking golangci-lint version
==> Running golangci-lint
0 issues.
==> Testing go-fastly
ok  	github.com/fastly/go-fastly/v12/fastly	(cached)
ok  	github.com/fastly/go-fastly/v12/fastly/computeacls	(cached)
?   	github.com/fastly/go-fastly/v12/fastly/domainmanagement	[no test files]
?   	github.com/fastly/go-fastly/v12/fastly/domainmanagement/v1	[no test files]
ok  	github.com/fastly/go-fastly/v12/fastly/domainmanagement/v1/domains	(cached)
?   	github.com/fastly/go-fastly/v12/fastly/domainmanagement/v1/tools	[no test files]
ok  	github.com/fastly/go-fastly/v12/fastly/domainmanagement/v1/tools/status	(cached)
ok  	github.com/fastly/go-fastly/v12/fastly/domainmanagement/v1/tools/suggest	(cached)
ok  	github.com/fastly/go-fastly/v12/fastly/imageoptimizerdefaultsettings	(cached)
?   	github.com/fastly/go-fastly/v12/fastly/impersonation	[no test files]
?   	github.com/fastly/go-fastly/v12/fastly/ngwaf	[no test files]
?   	github.com/fastly/go-fastly/v12/fastly/ngwaf/v1	[no test files]
ok  	github.com/fastly/go-fastly/v12/fastly/ngwaf/v1/lists	(cached)
ok  	github.com/fastly/go-fastly/v12/fastly/ngwaf/v1/rules	(cached)
?   	github.com/fastly/go-fastly/v12/fastly/ngwaf/v1/scope	[no test files]
ok  	github.com/fastly/go-fastly/v12/fastly/ngwaf/v1/signals	(cached)
ok  	github.com/fastly/go-fastly/v12/fastly/ngwaf/v1/workspaces	(cached)
?   	github.com/fastly/go-fastly/v12/fastly/ngwaf/v1/workspaces/alerts	[no test files]
ok  	github.com/fastly/go-fastly/v12/fastly/ngwaf/v1/workspaces/alerts/datadog	(cached)
ok  	github.com/fastly/go-fastly/v12/fastly/ngwaf/v1/workspaces/alerts/jira	(cached)
ok  	github.com/fastly/go-fastly/v12/fastly/ngwaf/v1/workspaces/alerts/mailinglist	(cached)
ok  	github.com/fastly/go-fastly/v12/fastly/ngwaf/v1/workspaces/alerts/microsoftteams	(cached)
ok  	github.com/fastly/go-fastly/v12/fastly/ngwaf/v1/workspaces/alerts/opsgenie	(cached)
ok  	github.com/fastly/go-fastly/v12/fastly/ngwaf/v1/workspaces/alerts/pagerduty	(cached)
ok  	github.com/fastly/go-fastly/v12/fastly/ngwaf/v1/workspaces/alerts/slack	(cached)
ok  	github.com/fastly/go-fastly/v12/fastly/ngwaf/v1/workspaces/alerts/webhook	(cached)
ok  	github.com/fastly/go-fastly/v12/fastly/ngwaf/v1/workspaces/events	(cached)
ok  	github.com/fastly/go-fastly/v12/fastly/ngwaf/v1/workspaces/redactions	(cached)
ok  	github.com/fastly/go-fastly/v12/fastly/ngwaf/v1/workspaces/requests	(cached)
ok  	github.com/fastly/go-fastly/v12/fastly/ngwaf/v1/workspaces/thresholds	(cached)
ok  	github.com/fastly/go-fastly/v12/fastly/ngwaf/v1/workspaces/timeseries	(cached)
ok  	github.com/fastly/go-fastly/v12/fastly/ngwaf/v1/workspaces/virtualpatches	(cached)
?   	github.com/fastly/go-fastly/v12/fastly/objectstorage	[no test files]
ok  	github.com/fastly/go-fastly/v12/fastly/objectstorage/accesskeys	(cached)
?   	github.com/fastly/go-fastly/v12/fastly/products	[no test files]
ok  	github.com/fastly/go-fastly/v12/fastly/products/apidiscovery	7.728s
ok  	github.com/fastly/go-fastly/v12/fastly/products/botmanagement	(cached)
ok  	github.com/fastly/go-fastly/v12/fastly/products/brotlicompression	(cached)
ok  	github.com/fastly/go-fastly/v12/fastly/products/ddosprotection	(cached)
ok  	github.com/fastly/go-fastly/v12/fastly/products/domaininspector	(cached)
ok  	github.com/fastly/go-fastly/v12/fastly/products/fanout	(cached)
ok  	github.com/fastly/go-fastly/v12/fastly/products/imageoptimizer	(cached)
ok  	github.com/fastly/go-fastly/v12/fastly/products/logexplorerinsights	(cached)
ok  	github.com/fastly/go-fastly/v12/fastly/products/ngwaf	(cached)
ok  	github.com/fastly/go-fastly/v12/fastly/products/origininspector	(cached)
ok  	github.com/fastly/go-fastly/v12/fastly/products/websockets	(cached)
ok  	github.com/fastly/go-fastly/v12/internal/productcore	(cached)
?   	github.com/fastly/go-fastly/v12/internal/test_utils	[no test files]

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

  • What is the user impact of this change?

Are there any considerations that need to be addressed for release?

@kpfleming kpfleming marked this pull request as ready for review September 29, 2025 18:35
@kpfleming kpfleming requested a review from a team as a code owner September 29, 2025 18:35
@kpfleming kpfleming requested a review from rcaril September 29, 2025 18:35
Copy link
Contributor

@rcaril rcaril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just wasn't sure about two of the fixtures I commented on.

@kpfleming kpfleming merged commit fdc1dec into fastly:main Sep 29, 2025
5 checks passed
@kpfleming kpfleming deleted the cdtool-1136 branch September 29, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants