connmgr: make new buffers for every client request#48327
Merged
Conversation
deg4uss3r
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when a client (outbound) request completes as part of a series of requests when following redirects, the connection buffers are not cleared between requests nor are they always resized down (the resize only happens if the connection is persistent). We should always be clearing+resizing between requests. This PR fixes the issue by simply reconstructing the connection buffers for every request. This is done by moving their construction into the inner loop.
(The odd resize-only-when-persistent behavior is likely due to the client handler code originally being adapted from the server handler code. In the server handling, if a connection isn't persistent then the buffers are simply destroyed and the task ends, so there is no chance of using an expanded write buffer in a subsequent request, but the client handling works differently with the loop to follow redirects.)