proxy/handler: send logs via the rust log crate#48334
Merged
Conversation
69ec35a to
c94b135
Compare
clintjedwards
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when calling C++ code from Rust, any logging performed by the C++ code won't behave properly unless the C++ logger is also initialized. We have similar problems going the other direction. This PR attempts to consolidate all logging from either language to use the Rust logger by:
If the Rust logger is not initialized then the C++ logging functions will behave based on the C++ logger configuration. The only programs left doing this are the legacy runner and m2adapter, which are deprecated.